Birmingham | 26-ITP-May | Lesya Lyaisyan | Sprint 2 | Wireframe#1360
Open
LesyaLyan wants to merge 6 commits into
Open
Birmingham | 26-ITP-May | Lesya Lyaisyan | Sprint 2 | Wireframe#1360LesyaLyan wants to merge 6 commits into
LesyaLyan wants to merge 6 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LesyaLyan
added
Needs Review
Stephanieewelu
approved these changes
May 28, 2026
Stephanieewelu
left a comment
Stephanieewelu
left a comment
There was a problem hiding this comment.
This is a well-written, beginner-friendly HTML page about README files, Wireframes, and Git Branches.
Strengths
• Correct semantic HTML (
• Proper heading hierarchy (one
, then
s)
• All images have alt text
• loading="lazy" and fetchpriority="high" used correctly
• Meta description and lang="en" present
Issues to Fix
• External links are missing target="_blank" rel="noopener noreferrer"
• Inconsistent image sizes — first image is 600×300 , others are 200×250
• Wireframe Wikipedia URL should be /wiki/Website_wireframe , not /wiki/Wireframe
• Footer could include a copyright symbol/year for polish
Author
|
Thank you for your review. I have made changes in the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Wrote a new webpage explaining the purposes of a README file, Wireframe and Git
Branches, Using the provided wireframe and resources.